fix(eventstore): Revert Nodestore changes in get_events #16518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpacifici
approved these changes
Jan 17, 2020
lynnagara
added a commit
that referenced
this pull request
Jan 27, 2020
…)" This reverts commit ef59aec. Now that we are caching nodestore data, try using nodestore for get_events again.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts eventstore changes introduced in #16230, which bind node data. Since loading from nodestore is slower than expected we will attempt this change again once node data caching is introduced.
I am not using reverting the entire commit since we still want to keep the search_message / message improvements that were included in the original.