fix(py3): Fix test_unmerge tests, and unsafe uses of dict.values() #20853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issues here were: - Indexing into `dict.values()`, which fails in py3 since it's a view. Audited the rest of the codebase to find other unsafe uses. - md5 not being passed bytes
markstory
approved these changes
Sep 18, 2020
jan-auer
added a commit
that referenced
this pull request
Sep 21, 2020
* master: (56 commits) fix(releases): Use sql formatting instead of string formatting for list of ids (#20875) ref(rediscluster): Reset cluster nodes and retry on ClusterError (#20859) ref(eventattachment): Use the local type column of EventAttachment in queries (#20785) remove message from skip fields (#20870) fix(py3): Fix tests in test_organization_group_index (#20848) check if highight children is proper string (#20867) fix(ui) Fix alignment of ? icons in headings (#20865) feat(alerts): Unflag metric alerts time selector (#20851) change to most regressed (#20861) fix(py3): Fix test_eventstream tests (#20850) fix(py3): Fix OrganizationEventsV2EndpointTest.test_sort_invalid (#20846) fix(py3): Fix test_unmerge tests, and unsafe uses of dict.values() (#20853) fix(py3): Fix test_optimized_aggregates test (#20852) fix(tests) Add discover integration tests to snuba makefile (#20840) feat(relay): Add public_key to RelayUsage (#20836) feat(similarity): Ability to diff grouping components (#20813) feat: Remove releases v2 flag checks (#20777) feat(workflow): Dynamic counts chart buckets and no filtered stats except issue list (#20824) adds x frame options back (#20844) fix(py3): Fix test_organization_events_stats tests in py3 (#20833) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues here were:
dict.values(), which fails in py3 since it's a view. Audited the rest of thecodebase to find other unsafe uses.