Skip to content

ref(vitals): Restructure vitals cards #23056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zylphrex merged 4 commits into from
Jan 15, 2021
Merged

ref(vitals): Restructure vitals cards #23056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b41c91d
ref(vitals): Restructure vitals cards
Zylphrex Jan 12, 2021
560c50b
add loading/empty states
Zylphrex Jan 13, 2021
76c280f
reduce number of redundant components
Zylphrex Jan 13, 2021
2aa4d7d
Merge branch 'master' into ref/restructure-vitals-cards
Zylphrex Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/sentry/static/sentry/app/views/performance/landing/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
LANDING_DISPLAYS,
LandingDisplayField,
} from './utils';
import VitalsCards from './vitalsCards';
import {FrontendCards} from './vitalsCards';

type Props = {
organization: Organization;
Expand Down Expand Up @@ -133,11 +133,11 @@ class LandingContent extends React.Component<Props, State> {
</DropdownControl>
</ProjectTypeDropdown>
</SearchContainer>
<VitalsCards
<FrontendCards
eventView={frontendEventView}
organization={organization}
location={location}
isAlwaysShown
projects={projects}
/>
{currentLandingDisplay.field === LandingDisplayField.FRONTEND && (
<FrontendDisplay
Expand Down Expand Up @@ -173,10 +173,12 @@ class LandingContent extends React.Component<Props, State> {
onSearch={handleSearch}
/>
<Feature features={['performance-vitals-overview']}>
<VitalsCards
<FrontendCards
eventView={eventView}
organization={organization}
location={location}
projects={projects}
frontendOnly
/>
</Feature>
<Charts
Expand Down
Loading