feat(demo): make DEMO_MODE off by default #24396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
approved these changes
Mar 11, 2021
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
Good stuff, I like shrinking the demo footprint here
|
|
||
| class DemoOrgManagerTeest(TestCase): | ||
| @override_settings(DEMO_ORG_OWNER_EMAIL=org_owner_email) | ||
| @override_settings(DEMO_MODE=True, DEMO_ORG_OWNER_EMAIL=org_owner_email) |
Member
There was a problem hiding this comment.
You can set @override_settings on a class as well. Does it make sense to make a DemoModeTestCase where we set this, then you don't need to set it on every test you write?
Could do the same thing for any views, have DemoModeViewTestCase and set the urlconf, although not sure how many views you're likely to have.
Contributor
Author
There was a problem hiding this comment.
@wedamija good call! Just made that change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I had added
DEMO_MODE=Truein our pytest file so that all tests boot up in demo mode. This was because I needed the demo start route exposed and simply using@override_settings(DEMO_MODE=True)wasn't enough. Instead, I am making a separate URL file that demo mode will use and use@override_settings(DEMO_MODE=True, ROOT_URLCONF="sentry.demo.urls")to the routes in tests. This has the impact of making demo mode off by default which is preferable.