From 061080d62934d0f887371b5814a8037ed2ecdee9 Mon Sep 17 00:00:00 2001 From: Danny Lee Date: Wed, 14 Apr 2021 22:43:14 -0700 Subject: [PATCH] fix(ts): Improve type for errors on AsyncComponent --- src/sentry/static/sentry/app/components/asyncComponent.tsx | 2 +- .../static/sentry/app/views/dashboardsV2/orgDashboards.tsx | 2 +- .../static/sentry/app/views/eventsV2/eventDetails/content.tsx | 2 +- src/sentry/static/sentry/app/views/eventsV2/landing.tsx | 2 +- .../sentry/app/views/performance/transactionDetails/content.tsx | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/sentry/static/sentry/app/components/asyncComponent.tsx b/src/sentry/static/sentry/app/components/asyncComponent.tsx index 1c1a1cce89176d..c94ba4917c239e 100644 --- a/src/sentry/static/sentry/app/components/asyncComponent.tsx +++ b/src/sentry/static/sentry/app/components/asyncComponent.tsx @@ -21,7 +21,7 @@ type AsyncComponentState = { loading: boolean; reloading: boolean; error: boolean; - errors: object; + errors: Record; remainingRequests?: number; [key: string]: any; }; diff --git a/src/sentry/static/sentry/app/views/dashboardsV2/orgDashboards.tsx b/src/sentry/static/sentry/app/views/dashboardsV2/orgDashboards.tsx index 6d595ab9ca6d14..ec0c6467e5ec9a 100644 --- a/src/sentry/static/sentry/app/views/dashboardsV2/orgDashboards.tsx +++ b/src/sentry/static/sentry/app/views/dashboardsV2/orgDashboards.tsx @@ -45,7 +45,7 @@ class OrgDashboards extends AsyncComponent { loading: true, reloading: false, error: false, - errors: [], + errors: {}, dashboards: [], selectedDashboard: null, diff --git a/src/sentry/static/sentry/app/views/eventsV2/eventDetails/content.tsx b/src/sentry/static/sentry/app/views/eventsV2/eventDetails/content.tsx index 76395558ff14fb..1ef125dbf2218c 100644 --- a/src/sentry/static/sentry/app/views/eventsV2/eventDetails/content.tsx +++ b/src/sentry/static/sentry/app/views/eventsV2/eventDetails/content.tsx @@ -67,7 +67,7 @@ class EventDetailsContent extends AsyncComponent { loading: true, reloading: false, error: false, - errors: [], + errors: {}, event: undefined, // local state diff --git a/src/sentry/static/sentry/app/views/eventsV2/landing.tsx b/src/sentry/static/sentry/app/views/eventsV2/landing.tsx index 8df06f424d0e98..985188d8ba512c 100644 --- a/src/sentry/static/sentry/app/views/eventsV2/landing.tsx +++ b/src/sentry/static/sentry/app/views/eventsV2/landing.tsx @@ -70,7 +70,7 @@ class DiscoverLanding extends AsyncComponent { loading: true, reloading: false, error: false, - errors: [], + errors: {}, // local component state isBannerHidden: isBannerHidden(), diff --git a/src/sentry/static/sentry/app/views/performance/transactionDetails/content.tsx b/src/sentry/static/sentry/app/views/performance/transactionDetails/content.tsx index 67446d009d566b..cb380b2985f67a 100644 --- a/src/sentry/static/sentry/app/views/performance/transactionDetails/content.tsx +++ b/src/sentry/static/sentry/app/views/performance/transactionDetails/content.tsx @@ -56,7 +56,7 @@ class EventDetailsContent extends AsyncComponent { loading: true, reloading: false, error: false, - errors: [], + errors: {}, event: undefined, // local state