-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: Emit breakdowns for all transactions #25886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
k-fish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
7e00b18 to
95b8254
Compare
|
@untitaker It seems like we have these assertions in the Relay project options tests (and in other places): sentry/tests/sentry/api/endpoints/test_relay_projectconfigs_v2.py Lines 107 to 109 in cbd0e17
And enabling the breakdowns project options is failing these assertions. The project options are as follows: Can you advise if the dictionary keys should not contain hyphens or underscores? |
|
@dashed we used to have a bug where we accidentally returned snakecase for all options in Sentry even though they were encoded as camelCase in Relay. If it is possible I would make every key/literal/constant/symbol in project config camelCase for consistency. Just took a quick look around the code, so I hope the following makes sense. I would:
|
cdb86ad to
ec7d788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fb91b52 to
7951c5b
Compare
| 1: { | ||
| "span_ops": { | ||
| "type": "span_operations", | ||
| "type": "spanOperations", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@untitaker I'm going to rename this to camel case for the project options.
untitaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please absolutely make sure to merge the Relay PR and deploy it first.
|
/gcbrun |
7951c5b to
a32e32c
Compare
Begin emitting breakdowns for all transactions. The
performance-ops-breakdownwill instead be used to gate the UI product features for displaying these breakdowns.Related PR: getsentry/relay#993