Fix assignment notifications. #2598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Is this just 100% broken? Or only broken in some scenarios? |
Member
|
|
Contributor
Author
Yep, totally broken. |
tkaemming
pushed a commit
that referenced
this pull request
Jan 25, 2016
Fix assignment notifications.
Contributor
Author
|
(Tests passed locally, just went and merged since Travis build is stuck.) |
mattrobenolt
pushed a commit
that referenced
this pull request
Jan 28, 2016
Fix assignment notifications.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken at some point by comparing a string to an integer, this
corrects the comparison and adds a test to ensure this doesn't break again in
the future.