Skip to content

Conversation

@benvinegar
Copy link
Contributor

Fixed by moving the deletion logic higher to a higher-level container component (the component that does the actual DOM removal when the GroupStore changes).

@benvinegar
Copy link
Contributor Author

cc @mattrobenolt

@codecov-io
Copy link

Current coverage is 83.22%

Merging #2636 into master will not affect coverage as of d71887c

@@            master   #2636   diff @@
======================================
  Files          864     864       
  Stmts        32664   32664       
  Branches         0       0       
  Methods          0       0       
======================================
- Hit          27186   27183     -3
  Partial          0       0       
- Missed        5478    5481     +3

Review entire Coverage Diff as of d71887c


Uncovered Suggestions

  1. +0.07% via ...try/utils/apidocs.py#414...436
  2. +0.07% via ...try/utils/apidocs.py#117...139
  3. +0.06% via ...gs/sentry_helpers.py#191...211
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

benvinegar added a commit that referenced this pull request Feb 3, 2016
Fix comment HTTP updates canceled via race condition (fixes #2603)
@benvinegar benvinegar merged commit 34e0d7f into master Feb 3, 2016
@benvinegar benvinegar deleted the GH-2603 branch February 3, 2016 23:41
mattrobenolt pushed a commit that referenced this pull request Feb 6, 2016
Fix comment HTTP updates canceled via race condition (fixes #2603)
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants