fix(stack-trace): Forward 403 Errors #26597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
mgaeta
force-pushed
the
fix/stacktrace-403
branch
from
ad48961 to
e840a7d
Compare
ceorourke
approved these changes
Jul 26, 2021
Member
ceorourke
left a comment
ceorourke
left a comment
There was a problem hiding this comment.
lgtm, maybe @NisanthanNanthakumar will have more context here though since it's stacktrace linking related. I'm not sure this actually fixes the linked Sentry issue (is that the right one? because it seems to be plugin issues about Pushover).
mgaeta
force-pushed
the
fix/stacktrace-403
branch
from
39947ab to
3dc66cb
Compare
Contributor
Author
|
@NisanthanNanthakumar I just rebased this branch can you take another look? |
NisanthanNanthakumar
approved these changes
Nov 1, 2021
Contributor
size-limit report
|
mgaeta
force-pushed
the
fix/stacktrace-403
branch
from
cb36402 to
195ee70
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-QQG.
There is an unhandled exception in stacktrace links when the user's GitHub account is suspended.