fix(semver): Fix semver backfill when version numbers are larger than a bigint #26608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanpurkhiser
approved these changes
Jun 14, 2021
… a bigint This fixes an edge case where we end up with major/minor/patch/revision numbers that end up larger than a postgres bigint can handle. We just skip these, since we have no way to store them.
wedamija
force-pushed
the
danf/semver_backfill_fix_bigints
branch
from
7f39bca to
5857bbd
Compare
Member
|
Force merging this as modifying the migration is intentional here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an edge case where we end up with major/minor/patch/revision numbers that end up larger
than a postgres bigint can handle. We just skip these, since we have no way to store them.