From 8f48aa3f6fca888807b61ce6a1e1c740b8198a95 Mon Sep 17 00:00:00 2001 From: Joshua Li Date: Tue, 31 Aug 2021 09:33:50 -0700 Subject: [PATCH] rename view method to avoid clashing with new setup view method intro'd in Django 2.2 --- .../endpoints/organization_events_facets_performance.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/sentry/api/endpoints/organization_events_facets_performance.py b/src/sentry/api/endpoints/organization_events_facets_performance.py index 6109db052f2a44..0b3dd63ee1f8fe 100644 --- a/src/sentry/api/endpoints/organization_events_facets_performance.py +++ b/src/sentry/api/endpoints/organization_events_facets_performance.py @@ -36,7 +36,10 @@ def has_feature(self, organization, request): def has_tag_page_feature(self, organization, request): return features.has("organizations:performance-tag-page", organization, actor=request.user) - def setup(self, request, organization): + # NOTE: This used to be called setup, but since Django 2.2 it's a View method. + # We don't fit its semantics, but I couldn't think of a better name, and + # it's only used in child classes. + def _setup(self, request, organization): if not ( self.has_feature(organization, request) or self.has_tag_page_feature(organization, request) @@ -63,7 +66,7 @@ def setup(self, request, organization): class OrganizationEventsFacetsPerformanceEndpoint(OrganizationEventsFacetsPerformanceEndpointBase): def get(self, request, organization): try: - params, aggregate_column, filter_query = self.setup(request, organization) + params, aggregate_column, filter_query = self._setup(request, organization) except NoProjects: return Response([]) @@ -134,7 +137,7 @@ def has_feature(self, organization, request): def get(self, request, organization): try: - params, aggregate_column, filter_query = self.setup(request, organization) + params, aggregate_column, filter_query = self._setup(request, organization) except NoProjects: return Response([])