fix(codeowners): Return missing member's email #28907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaeta
reviewed
Sep 30, 2021
| users_dict[external_actor.external_name] = user.email | ||
| else: | ||
| users_without_access.append(f"{user.username}") | ||
| users_without_access.append(f"{user.get_display_name()}") |
Contributor
There was a problem hiding this comment.
def get_display_name(self):
return self.name or self.email or self.usernameThis might return the user's name is that OK?
Contributor
Author
There was a problem hiding this comment.
@mgaeta yea it should be fine bc it'll only return if there's no email or name.
mgaeta
approved these changes
Sep 30, 2021
NisanthanNanthakumar
deleted the
fix/codeowners-show-missing-member-emails
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.