Skip to content

ref(ui): Remove LightWeightNoProjectMessage #28988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matejminar merged 1 commit into from
Oct 1, 2021
Merged

ref(ui): Remove LightWeightNoProjectMessage #28988

matejminar merged 1 commit into from
Oct 1, 2021

Conversation

@matejminar
Copy link
Member

@matejminar matejminar commented Sep 30, 2021

Now that there's no distinction between lightweight and heavyweight routes, we can get rid of LightWeightNoProjectMessage component.

@matejminar matejminar marked this pull request as ready for review September 30, 2021 12:12
@matejminar matejminar requested a review from a team as a code owner September 30, 2021 12:12
@matejminar matejminar requested review from a team September 30, 2021 12:12
scttcper
scttcper approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

davidenwang
davidenwang approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@davidenwang davidenwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing

scttcper added a commit that referenced this pull request Sep 30, 2021
@scttcper
lightweight no project message -> no project message
336cfa0 
depends on #28988
@scttcper scttcper mentioned this pull request Sep 30, 2021
Merged
@matejminar matejminar merged commit c9cae71 into master Oct 1, 2021
@matejminar matejminar deleted the ref/remove-lightweight-no-project-message branch October 1, 2021 09:11
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@scttcper scttcper scttcper approved these changes

+1 more reviewer

@davidenwang davidenwang davidenwang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matejminar @scttcper @davidenwang