ref: Add types to store and symbolication #29014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
reviewed
Oct 1, 2021
relaxolotl
force-pushed
the
ref/split-store
branch
from
c760372 to
023645f
Compare
ingest can stop being pulled in for reviews on PRs that do not require their feedback or should not require their feedback NATIVE-259
relaxolotl
force-pushed
the
ref/split-store
branch
from
023645f to
a2212cd
Compare
relaxolotl
force-pushed
the
ref/store-symbolication-types
branch
from
a3c1d26 to
9054b45
Compare
Swatinem
reviewed
Oct 4, 2021
Contributor
Swatinem
left a comment
Swatinem
left a comment
There was a problem hiding this comment.
lgtm from my limited understanding of this. I do have two Q however:
- is removal of
submit_process/projectreally safe? I saw one callsite that was updated. is that all? - what @untitaker sayd about
kwargs. I know way too little about how they really work.
loewenheim
force-pushed
the
ref/split-store
branch
from
a2212cd to
c760372
Compare
flub
approved these changes
Oct 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds type checking to
tasks/store.pyandtasks/symbolication.py. The only place where I'm not sure I did the right thing iscreate_failed_event; I gaveissuesandreprocessing_revthe typesList[Dict[str, str]]andAny, respectively.