ref(slack): Clean MessageBuilder #29063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgaeta
force-pushed
the
fix/api-2163-slack-actions
branch
from
18eaa1a to
999af82
Compare
mgaeta
force-pushed
the
fix/api-2163-slack-actions
branch
from
07196e4 to
9670f86
Compare
mgaeta
force-pushed
the
fix/api-2163-slack-actions
branch
from
9670f86 to
aea306e
Compare
mgaeta
changed the title
mgaeta
force-pushed
the
fix/api-2163-slack-actions-2
branch
2 times, most recently
from
89b6303 to
fcea1a6
Compare
mgaeta
force-pushed
the
fix/api-2163-slack-actions
branch
from
b061a88 to
83295c3
Compare
mgaeta
force-pushed
the
fix/api-2163-slack-actions
branch
from
7f0cca2 to
294802f
Compare
Contributor
Author
|
@leeandher I just rebased this branch can you take another look? |
leeandher
approved these changes
Nov 1, 2021
Comment on lines
+299
to
+311
| external_issue_subquery = ExternalIssue.objects.get_for_integration( | ||
| integration, external_issue_key | ||
| ).values_list("id", flat=True) | ||
|
|
||
| group_link_subquery = GroupLink.objects.filter( | ||
| linked_id__in=external_issue_subquery | ||
| ).values_list("group_id", flat=True) | ||
|
|
||
| return self.filter( | ||
| id__in=GroupLink.objects.filter( | ||
| linked_id__in=ExternalIssue.objects.filter( | ||
| key=external_issue_key, | ||
| integration_id=integration.id, | ||
| organization_id__in=integration.organizations.values_list("id", flat=True), | ||
| ).values_list("id", flat=True) | ||
| ).values_list("group_id", flat=True), | ||
| project__organization_id__in=integration.organizations.values_list("id", flat=True), | ||
| ) | ||
| id__in=group_link_subquery, | ||
| project__organization__in=organizations, | ||
| project__organization__organizationintegration__integration=integration, | ||
| ).select_related("project") |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
build_actions()to use helpers and types.