fix: Remove clone annotations during function trimming (NATIVE-110) #29105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it would *use* the clone annotation as the trimmed function name, which is plain wrong and was confusing customers (and ourselves as well). This also has a small fix for `operator->` losing its angle bracket under some circumstances.
loewenheim
reviewed
Oct 6, 2021
loewenheim
approved these changes
Oct 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it would use the clone annotation as the trimmed function name,
which is plain wrong and was confusing customers (and ourselves as well).
This also has a small fix for
operator->losing its angle bracket under somecircumstances.