ref: Remove JS tests from precommit #29155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those tests were added because people kept forgetting updating snapshot files. However, we don't have those anymore. Meanwhile backend devs see the entire js testsuite executing when they merge master into their branch This relates to, but doesn't fully solve #25291, as JS lints still run on `git merge master`. In the longer-term it might be best to move everything to pre-commit.yml which doesn't do that.
untitaker
commented
Oct 7, 2021
Comment on lines
-324
to
-326
| if py: | ||
| # python autoformatting is now done via pre-commit (black) | ||
| pass |
Member
Author
There was a problem hiding this comment.
I don't see an obvious reason as to why if x: pass is something worthwhile to keep in code...
dashed
approved these changes
Oct 7, 2021
joshuarli
approved these changes
Oct 7, 2021
Member
joshuarli
left a comment
joshuarli
left a comment
There was a problem hiding this comment.
nice, now i don't have to rm .git/hooks/pre-commit.legacy anymore
priscilawebdev
approved these changes
Oct 15, 2021
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
…-from-lint-engine
Member
Author
|
@flub yes, two reasons: flaky CI and short attention span :P |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests were added because people kept forgetting updating snapshot
files. However, we don't have those anymore.
Meanwhile backend devs see the entire js testsuite executing when they
merge master into their branch
This relates to, but doesn't fully solve
#25291, as JS lints still run
on
git merge master. In the longer-term it might be best to moveeverything to pre-commit.yml which doesn't do that.