feat(perf): Add landing widgets for most issues and errors #29209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
This adds some list components and a new widget type for chart/list hybrid widgets. It's called lineChartListWidget currently, but is using the area widget for now since it's already setup with previous periods etc.
k-fish
force-pushed
the
feat/perf-landing-widgets-most-errors
branch
from
190b949 to
b5007a0
Compare
Zylphrex
previously requested changes
Oct 18, 2021
Member
Zylphrex
left a comment
Zylphrex
left a comment
There was a problem hiding this comment.
None of the comments are blocking as this is behind a feature flag and can be addressed in a follow-up.
| setNextWidgetData({...nextWidgetData, [dataKey]: result}); | ||
| } | ||
| if (result?.hasData || result?.isErrored) { | ||
| setNextWidgetData({...nextWidgetData, [dataKey]: result}); |
Member
There was a problem hiding this comment.
Is this call necessary? If result?.hasData || result?.isErrored ever evaluates to true, result will always be true and set the widget data to the same thing right?
| results: GenericChildrenProps<TableData>, | ||
| _: QueryDefinitionWithKey<T> | ||
| ) { | ||
| const {start, end, utc, interval, statsPeriod} = getParams(widgetProps.location.query); |
Member
There was a problem hiding this comment.
Is this using the default stats period of 14d? Performance uses 24h.
| eventView.additionalConditions.setFilterValues('event.type', ['error']); | ||
| eventView.additionalConditions.setFilterValues('!tags[transaction]', ['']); | ||
| const mutableSearch = new MutableSearch(eventView.query); | ||
| mutableSearch.removeFilter('transaction.duration'); |
Member
There was a problem hiding this comment.
I think you want to do something similar to how related issues work and remove all tracing fields and a few other things as well. And repeat this for all the places that need it.
Zylphrex
approved these changes
Oct 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds some list components and a new widget type for chart/list hybrid widgets. It's called lineChartListWidget currently, but is using the area widget for now since it's already setup with previous periods etc.
Other
Also adds a generic selectable list with radio buttons that handles display. State for the index selected is still owned by the parent component.