ref(ui): Change from withTeams to <Teams> for team key transactions #29223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
davidenwang
commented
Oct 11, 2021
static/app/views/performance/transactionSummary/teamKeyTransactionButton.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/transactionSummary/teamKeyTransactionButton.tsx
Outdated
Show resolved
Hide resolved
Zylphrex
approved these changes
Oct 13, 2021
Member
Zylphrex
left a comment
Zylphrex
left a comment
There was a problem hiding this comment.
Does the useTeams hook handle super users the same way? Previously, just filtering for isMember ignores super users privileges so we had to check isActiveSuperuser() as well.
| } | ||
|
|
||
| export const PerformanceLanding = withTeams(_PerformanceLanding); | ||
| export const PerformanceLanding = _PerformanceLanding; |
Member
There was a problem hiding this comment.
Nit: We can rename _PerformanceLanding to PerformanceLanding and directly export it now
Contributor
Author
There was a problem hiding this comment.
sounds good i'll refactor. Also, dang thanks for pointing out the superuser logic. We actually do fetch all teams if you're a superuser, but in the hook we're filtering it down to just teams where isMember is true. fixing here: #29294
davidenwang
force-pushed
the
davidenwang/use-teams-team-key-transaction
branch
from
66f1c02 to
b5bc68b
Compare
davidenwang
force-pushed
the
davidenwang/use-teams-team-key-transaction
branch
from
b5bc68b to
75830ae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how we fetch teams on the frontend we only load up to 100 into the TeamStore at app start. Only a handful of orgs have over 100 teams, but it still poses a problem for using certain features such as team key transactions. To fix this, we replace
withTeamsin favor of theTeamsutility which handles fetching the correct teams and propagating changes back to the store to prevent duplicate fetching.This PR replaces instances of withTeams in team key transactions with
Teamswhilst preserving the functionality. In some cases we have to add a loading spinner in the event that we don't have the user team's loaded in the team store.