fix(grouping): Correctly handle multiple threads in fingerprinting code #29231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
force-pushed
the
bugfix/fingerprinting-crashed-thread
branch
from
f1013cc to
b8ab3de
Compare
untitaker
approved these changes
Oct 18, 2021
Member
untitaker
left a comment
untitaker
left a comment
There was a problem hiding this comment.
hmm yeah. this duplication sucks. it would also make sense to update stack.* searches in discover to honor this.
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
…ng-crashed-thread
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the fingerprinting code diverged in behavior from the new grouping code with regards to grouping when multiple threads are in use. This now aligns the behavior so that not only does the grouping code work when a single thread is in the list, but also when a single thread is current or crashed.