fix(workflow): Add locks to groupowners to prevent duplicates #29309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wedamija
reviewed
Oct 14, 2021
src/sentry/tasks/post_process.py
Outdated
| GroupOwner.objects.bulk_create(new_group_owners) | ||
| lock = locks.get(f"groupowner-bulk:{group.id}", duration=10) | ||
| try: | ||
| with lock.acquire(): |
Member
There was a problem hiding this comment.
I'd recommend putting this lock around the entire block that is used to calculate new_group_owners, since that's where the duplication happens as well. Basically the same spot where we start using the timer.
wedamija
approved these changes
Oct 15, 2021
src/sentry/tasks/post_process.py
Outdated
Comment on lines
136
to
137
| with lock.acquire(): | ||
| with metrics.timer("post_process.handle_group_owners"): |
Member
There was a problem hiding this comment.
Nit: You can combine with statements together like
with lock.acquire(), metrics.timer("post_process.handle_group_owners"):
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES SENTRY-MP8
There's a race condition on creating group owners when there are multiple tasks. This adds a lock and should deduplicate extras?