fix(ui): GridEditable on resize cleanup #29392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the mouse up handler was not cleaning up correctly if no onResizeColumn handler was specified causing the resize to never stop. This ensures that the cleanup is properly executed after mouse up and stops the resize.
k-fish
approved these changes
Oct 19, 2021
Member
k-fish
left a comment
k-fish
left a comment
There was a problem hiding this comment.
I think I've run into this before, if so, thanks for fixing it 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the mouse up handler was not cleaning up correctly if no onResizeColumn
handler was specified causing the resize to never stop. This ensures that the
cleanup is properly executed after mouse up and stops the resize.