feat(discover): Add the snql feature flag to eventsv2 #29395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This also gets the last few tests passing
- Mocking the snql query too
- Adding an order to the user_misery test, not sure why this didn't
flake before, but definitely wasn't passing consistently now
- We don't allow sorting by issue in the UI, so i assume this is an
older test. Updated with a sort that does make sense
wmak
force-pushed
the
wmak/feat/eventsv2-with-snql
branch
from
ea2c40a to
7659182
Compare
Zylphrex
approved these changes
Oct 19, 2021
| "transaction", | ||
| "user_misery()", | ||
| ], | ||
| "orderby": "user_misery()", |
Member
There was a problem hiding this comment.
Was this test never flakey somehow? But 👍 to making the result more deterministic.
| assert abs(data[1]["user_misery"] - 0.06586) < 0.0001 | ||
| assert abs(data[2]["user_misery"] - 0.05751) < 0.0001 | ||
| assert abs(data[1]["user_misery"] - 0.05751) < 0.0001 | ||
| assert abs(data[2]["user_misery"] - 0.06586) < 0.0001 |
Member
There was a problem hiding this comment.
Thoughts on using pytest.approx going forwards?
Member
Author
There was a problem hiding this comment.
TIL, we can update in a future PR cc @shruthilayaj (as a btw not saying you're the one who has to do it)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake before, but definitely wasn't passing consistently now
older test. Updated with a sort that does make sense