fix(insights): Fix get_prev_history to fetch the correct previous history row for a status
#29425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedetefy
reviewed
Oct 20, 2021
src/sentry/models/grouphistory.py
Outdated
Contributor
There was a problem hiding this comment.
Does this require a migration?
ahmedetefy
approved these changes
Oct 20, 2021
…istory row for a status Previously this function would always just fetch the oldest history for a given group. This pr fixes it to look for the most recent row with a status that is considered the inverse of the status we're using to create the new row. Unresolved and resolved are opposites, as an example, and not all statuses have an inverse.
wedamija
force-pushed
the
danf/insights_fix_prev_history
branch
from
06d36b8 to
a72e021
Compare
Contributor
|
This PR has a migration; here is the generated SQL BEGIN;
--
-- Alter index_together for grouphistory (2 constraint(s))
--
CREATE INDEX "sentry_grouphistory_group_id_status_7ae79a2b_idx" ON "sentry_grouphistory" ("group_id", "status");
COMMIT; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this function would always just fetch the oldest history for a given group. This pr fixes
it to look for the most recent row with a status that is considered the inverse of the status we're
using to create the new row. Unresolved and resolved are opposites, as an example, and not all
statuses have an inverse.