feat(ui): project selector hook #29447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scefali
commented
Oct 20, 2021
| onUpdate={this.handleUpdateProjects} | ||
| multi={ | ||
| !disableMultipleProjectSelection && | ||
| this.hasMultipleProjectSelection() |
Contributor
Author
There was a problem hiding this comment.
Since we need to render the new hook project-selector-all-projects:customization even if the feature is unavailable, we need to push the logic down into the child component
Contributor
size-limit report
|
davidenwang
approved these changes
Oct 25, 2021
| customDisabledRender = hooks[0]; | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@davidenwang I did some stuff to this file then reverted it. Too lazy to revert this whitespace change lol.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hook called
feature-disabled:project-selector-all-projectswhich allows getsentry to customize a disabled view we show in the global header for showing the button which allows the user to select all/their projects. Note we also changed the text fromView All ProjectstoSelect All Projectsto make it more clear what it does.Logic about when to show
My ProjectsandAll Projectsis a bit confusing but the changes I have made should not impact when we do.Getsentry PR: https://github.com/getsentry/getsentry/pull/6486