feat(suspect-spans): Add suspect spans tab page #29453
Conversation
This replaces the place holder for the spans tab.
size-limit report
|
Zylphrex
force-pushed
the
feat/suspect-spans-tab
branch
from
7bf7d08 to
cb90b1e
Compare
k-fish
left a comment
k-fish
left a comment
There was a problem hiding this comment.
Let's gooo 🔥
I've checked this out locally and have a couple product things to discuss, we can chat about it offline though.
| } | ||
|
|
||
| if (!suspectSpans?.length) { | ||
| // TODO: empty state |
There was a problem hiding this comment.
Yep. Was just coming to look for this but I see it's already a TODO, I'd just actually put a EmptyStateWarning or something basic until we figure out what empty state we actually want.
There was a problem hiding this comment.
Will do that in a follow up
| > | ||
| {({suspectSpans, isLoading, error, pageLinks}) => { | ||
| if (error) { | ||
| setError(error); |
There was a problem hiding this comment.
Side note (doesn't really matter in this PR):
Instead of having to pass this in, I've also made the pageError context now along with an alert. You can just put the provider and alert in the topmost level, and use the hook here without needing it in props anymore.
| }, | ||
| { | ||
| prefix: t('Total'), | ||
| label: t('Occurrences'), |
There was a problem hiding this comment.
Occurrences / count / frequency are all still a bit confusing I think, doesn't matter for this PR we can discuss this offline.
There was a problem hiding this comment.
I think the exact wording is something we'll need to discuss as these concepts are all very similar and can be confusing.
This replaces the place holder for the spans tab.