Skip to content

Conversation

@scttcper
Copy link
Member

bar charts for some reason are missing the silent: boolean type but it will likely get added with echarts v5

@scttcper scttcper requested a review from a team October 21, 2021 00:19
@scttcper scttcper requested a review from a team as a code owner October 21, 2021 00:19
silent: true,
},
// silent is not incldued in the type for BarSeries
] as any[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about instead of as any[] you // @ts-expect-error or whatever, so it errors when we fix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That apparently doesn't work with multiple objects? It errors on the entire component for those rather then just on the silent property

@scttcper scttcper enabled auto-merge (squash) October 21, 2021 17:57
@scttcper scttcper merged commit 8540e8b into master Oct 21, 2021
@scttcper scttcper deleted the scttcper/disable-mouse-pointer-insights branch October 21, 2021 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants