feat(insights): Update GroupHistory.actor to set null on delete
#29469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to delete these rows if the actor that made the changes is deleted, just `SET_NULL` instead. Also corrected some comments
wedamija
force-pushed
the
danf/insights_fix_model
branch
from
0be706b to
5636892
Compare
Contributor
|
This PR has a migration; here is the generated SQL BEGIN;
--
-- Alter field actor on grouphistory
--
SET CONSTRAINTS "sentry_grouphistory_actor_id_085453d6_fk_sentry_actor_id" IMMEDIATE; ALTER TABLE "sentry_grouphistory" DROP CONSTRAINT "sentry_grouphistory_actor_id_085453d6_fk_sentry_actor_id";
ALTER TABLE "sentry_grouphistory" ADD CONSTRAINT "sentry_grouphistory_actor_id_085453d6_fk_sentry_actor_id" FOREIGN KEY ("actor_id") REFERENCES "sentry_actor" ("id") DEFERRABLE INITIALLY DEFERRED;
COMMIT; |
ahmedetefy
approved these changes
Oct 21, 2021
markstory
reviewed
Oct 21, 2021
| from sentry.models import Group, Release, Team, User | ||
|
|
||
|
|
||
| class GroupHistoryStatus: |
Member
There was a problem hiding this comment.
I noticed that this class isn't part of Group deletions, should it be?
Member
Author
There was a problem hiding this comment.
Yeah, I'll follow up with another PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to delete these rows if the actor that made the changes is deleted, just
SET_NULLinstead. Also corrected some comments