feat(ui): Reduce the number of re-fetches on release details #29507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Zylphrex
reviewed
Oct 22, 2021
| end, | ||
| organization.slug, | ||
| location.query.project, | ||
| location.query.environment, |
Member
There was a problem hiding this comment.
If I recall, environment here can be an array. And in that scenario, this useEffect will always re-run whenever the location changes since it will fail the Object.is check right?
| }; | ||
| } | ||
|
|
||
| componentDidUpdate(prevProps, prevContext: Record<string, any>) { |
Member
There was a problem hiding this comment.
wouldn't the second parameter be "prevState"?
Member
Author
There was a problem hiding this comment.
yeah, I think the confusion comes from this line:
We have it named like this in a couple of different places, can open a follow-up PR to rename it everywhere.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a couple of conditions to release details requests so that they re-fetch only when it's truly needed.
No need to call releases endpoint again if only the issues/transactions/chart filter changed (same for a couple of other endpoints).