feat(dashboards): Open in Discover on a Bar Chart widget displays in Bar Chart in Discover #29514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shruthilayaj
approved these changes
Oct 22, 2021
Member
shruthilayaj
left a comment
shruthilayaj
left a comment
There was a problem hiding this comment.
Looks good. Aside, I see that bar charts are stacked for multi-axis in discover but not in dashboard widgets. Should we eventually make those consistent?
Contributor
Author
Ahh good question. All our existing bar charts are stacked right now (Daily, Top Daily, and the new Bar Chart) so I wonder if we would need to update all of these. Personally I think we can just update Bar Chart to nonstacked and leave the Daily views as stacked. This can be a follow up ticket, let me check with the channel. |
edwardgou-sentry
deleted the
feat/dashboards-open-in-discover-bar-chart
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking the
Open in Discoverbutton on a Dashboard Widget will open Discover in Bar Chart view if the Widget is a Bar Chart Widget.