From 4f3f24a57a4e0bd300b384e0178bc92cd7e69b4b Mon Sep 17 00:00:00 2001 From: Edward Gou Date: Fri, 22 Oct 2021 11:57:25 -0400 Subject: [PATCH] Open in Discover on a Bar Chart widget now displays in Bar Chart in Discover --- .../modals/dashboardWidgetQuerySelectorModal.tsx | 9 +++++++++ static/app/views/dashboardsV2/widgetCard.tsx | 3 +++ 2 files changed, 12 insertions(+) diff --git a/static/app/components/modals/dashboardWidgetQuerySelectorModal.tsx b/static/app/components/modals/dashboardWidgetQuerySelectorModal.tsx index 33d6d71b4ec763..8dfc7e53ea4940 100644 --- a/static/app/components/modals/dashboardWidgetQuerySelectorModal.tsx +++ b/static/app/components/modals/dashboardWidgetQuerySelectorModal.tsx @@ -11,10 +11,12 @@ import {t} from 'app/locale'; import space from 'app/styles/space'; import {GlobalSelection, Organization} from 'app/types'; import trackAdvancedAnalyticsEvent from 'app/utils/analytics/trackAdvancedAnalyticsEvent'; +import {DisplayModes} from 'app/utils/discover/types'; import withApi from 'app/utils/withApi'; import withGlobalSelection from 'app/utils/withGlobalSelection'; import {Widget} from 'app/views/dashboardsV2/types'; import {eventViewFromWidget} from 'app/views/dashboardsV2/utils'; +import {DisplayType} from 'app/views/dashboardsV2/widget/utils'; import Input from 'app/views/settings/components/forms/controls/input'; export type DashboardWidgetQuerySelectorModalOptions = { @@ -45,6 +47,13 @@ class DashboardWidgetQuerySelectorModal extends React.Component { discoverLocation.query.yAxis = query.fields .filter(field => yAxisOptions.includes(field)) .slice(0, 3); + switch (widget.displayType) { + case DisplayType.BAR: + discoverLocation.query.display = DisplayModes.BAR; + break; + default: + break; + } return ( diff --git a/static/app/views/dashboardsV2/widgetCard.tsx b/static/app/views/dashboardsV2/widgetCard.tsx index 4cd9d6a7c59fc8..84fcfd2a1db31e 100644 --- a/static/app/views/dashboardsV2/widgetCard.tsx +++ b/static/app/views/dashboardsV2/widgetCard.tsx @@ -147,6 +147,9 @@ class WidgetCard extends React.Component { case DisplayType.WORLD_MAP: discoverLocation.query.display = DisplayModes.WORLDMAP; break; + case DisplayType.BAR: + discoverLocation.query.display = DisplayModes.BAR; + break; default: break; }