Skip to content

Conversation

@edwardgou-sentry
Copy link
Contributor

World Map display mode uses the events-geo endpoint which currently does not support equations.
Disabling equations from the y-axis dropdown selection when the user is in World Map display mode.

@edwardgou-sentry edwardgou-sentry requested a review from a team October 22, 2021 16:10
};
});
}
// Equations on World Map isn't supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the comment a bit more precise saying that the API endpoint doesn't support equations yet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Updated!

@edwardgou-sentry edwardgou-sentry merged commit 8349ad3 into master Oct 22, 2021
@edwardgou-sentry edwardgou-sentry deleted the fix/discover-world-map-disable-equations branch October 22, 2021 17:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants