Skip to content

build(ci): Fix boolean comparisons for GHA workflow #29524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 1 commit into from
Oct 25, 2021
Merged

build(ci): Fix boolean comparisons for GHA workflow #29524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/scripts/deploy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ module.exports = {
* determine what Freight deploy we can use.
*/
updateChangeType: async ({github, context, fileChanges}) => {
// Note that `fileChanges` bools and ints will get cast to strings
const {frontend, backend} = fileChanges;
const frontendOnly = frontend && !backend;
const backendOnly = backend && !frontend;
const frontendOnly = frontend === 'true' && backend === 'false';
const backendOnly = backend === 'true' && frontend === 'false';

const name = frontendOnly
? 'only frontend changes'
Expand Down