fix(discover): Correct display when unfurling top events charts #29537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some top events charts (like equations, some aggregations) should unfurl line charts to mimic discover.
wmak
approved these changes
Oct 26, 2021
| "previous": ChartType.SLACK_DISCOVER_PREVIOUS_PERIOD, | ||
| } | ||
|
|
||
| # All `multiPlotType: line` fields in /static/app/utils/discover/fields.tsx |
Member
There was a problem hiding this comment.
Should we add a corresponding comment in the fields.tsx file so we know to update both?
edwardgou-sentry
approved these changes
Oct 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some top events charts (like equations, some aggregations)
should unfurl line charts to mimic discover.
Screenshot:
