Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sentry/search/events/builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def __init__(
auto_aggregations: bool = False,
use_aggregate_conditions: bool = False,
functions_acl: Optional[List[str]] = None,
array_join: Optional[str] = None,
limit: Optional[int] = 50,
offset: Optional[int] = 0,
limitby: Optional[Tuple[str, int]] = None,
Expand All @@ -52,6 +53,7 @@ def __init__(

self.columns = self.resolve_select(selected_columns, equations)
self.orderby = self.resolve_orderby(orderby)
self.array_join = None if array_join is None else self.resolve_column(array_join)

def resolve_limitby(self, limitby: Optional[Tuple[str, int]]) -> Optional[LimitBy]:
if limitby is None:
Expand Down Expand Up @@ -122,6 +124,7 @@ def get_snql_query(self) -> Query:
dataset=self.dataset.value,
match=Entity(self.dataset.value),
select=self.columns,
array_join=self.array_join,
where=self.where,
having=self.having,
groupby=self.groupby,
Expand Down
21 changes: 21 additions & 0 deletions tests/sentry/search/events/test_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -434,3 +434,24 @@ def test_spans_columns(self):
),
],
)

def test_array_join_clause(self):
query = QueryBuilder(
Dataset.Discover,
self.params,
"",
selected_columns=[
"spans_op",
"count()",
],
array_join="spans_op",
)
self.assertCountEqual(
query.columns,
[
AliasedExpression(Column("spans.op"), "spans_op"),
Function("count", [], "count"),
],
)
assert query.array_join == Column("spans.op")
query.get_snql_query().validate()