From 1ccb219ab7f3b1ccaf3f6016f138bb7b3708353c Mon Sep 17 00:00:00 2001 From: Scott Cooper Date: Mon, 25 Oct 2021 14:19:37 -0700 Subject: [PATCH 1/3] feat(workflow): Enable several GA flags by default All of these flags were enabled for everyone in flagr --- src/sentry/conf/server.py | 8 ++++---- tests/sentry/api/serializers/test_organization.py | 4 ++++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/sentry/conf/server.py b/src/sentry/conf/server.py index 6206dccd35bb34..2316fd45058885 100644 --- a/src/sentry/conf/server.py +++ b/src/sentry/conf/server.py @@ -1056,7 +1056,7 @@ def create_partitioned_queues(name): # Enable version 2 of reprocessing (completely distinct from v1) "organizations:reprocessing-v2": False, # Enable sorting+filtering by semantic version of a release - "organizations:semver": False, + "organizations:semver": True, # Enable basic SSO functionality, providing configurable single sign on # using services like GitHub / Google. This is *not* the same as the signup # and login with Github / Azure DevOps that sentry.io provides. @@ -1081,13 +1081,13 @@ def create_partitioned_queues(name): # Enable the mobile screenshots feature "organizations:mobile-screenshots": False, # Enable the adoption chart in the releases page - "organizations:release-adoption-chart": False, + "organizations:release-adoption-chart": True, # Enable the release adoption stage labels and sorting+filtering by them - "organizations:release-adoption-stage": False, + "organizations:release-adoption-stage": True, # Store release bundles as zip files instead of single files "organizations:release-archives": False, # Enable the new release details experience - "organizations:release-comparison": False, + "organizations:release-comparison": True, # Enable the release details performance section "organizations:release-comparison-performance": False, # Enable percent displays in issue stream diff --git a/tests/sentry/api/serializers/test_organization.py b/tests/sentry/api/serializers/test_organization.py index fdfe138118e638..d7be73746185d3 100644 --- a/tests/sentry/api/serializers/test_organization.py +++ b/tests/sentry/api/serializers/test_organization.py @@ -44,6 +44,10 @@ def test_simple(self): "performance-tag-page", "performance-tag-explorer", "relay", + "release-adoption-chart", + "release-adoption-stage", + "release-comparison", + "semver", "shared-issues", "sso-basic", "sso-saml2", From a1bd85244698e395837be4c15a5926a1d7017054 Mon Sep 17 00:00:00 2001 From: Scott Cooper Date: Mon, 25 Oct 2021 14:56:41 -0700 Subject: [PATCH 2/3] disable feature for test --- .../api/endpoints/test_organization_release_details.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/sentry/api/endpoints/test_organization_release_details.py b/tests/sentry/api/endpoints/test_organization_release_details.py index f1e52576c0ca17..d9e95de0795cb4 100644 --- a/tests/sentry/api/endpoints/test_organization_release_details.py +++ b/tests/sentry/api/endpoints/test_organization_release_details.py @@ -609,10 +609,11 @@ def test_with_adoption_stages(self): "sentry-api-0-organization-release-details", kwargs={"organization_slug": self.organization.slug, "version": release1.version}, ) - response = self.client.get(f"{url}?adoptionStages=1", format="json") - assert response.status_code == 200, response.content - # Not returned because we don't have the feature. - assert "adoptionStages" not in response.data + with self.feature({"organizations:release-adoption-stage": False}): + response = self.client.get(f"{url}?adoptionStages=1", format="json") + assert response.status_code == 200, response.content + # Not returned because we don't have the feature. + assert "adoptionStages" not in response.data with self.feature("organizations:release-adoption-stage"): response = self.client.get(url, format="json") From ef66c6c0374d57a2a439cfee5e91bacf5663a593 Mon Sep 17 00:00:00 2001 From: Scott Cooper Date: Tue, 26 Oct 2021 09:55:22 -0700 Subject: [PATCH 3/3] disable feature flag --- .../api/endpoints/test_organization_releases.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/sentry/api/endpoints/test_organization_releases.py b/tests/sentry/api/endpoints/test_organization_releases.py index a0a375fad48952..69a947e048341f 100644 --- a/tests/sentry/api/endpoints/test_organization_releases.py +++ b/tests/sentry/api/endpoints/test_organization_releases.py @@ -817,12 +817,14 @@ def test_with_adoption_stages(self): ) release1.add_project(project1) url = reverse("sentry-api-0-organization-releases", kwargs={"organization_slug": org.slug}) - response = self.client.get(f"{url}?adoptionStages=1", format="json") - assert response.status_code == 200, response.content - assert len(response.data) == 1 - # Not returned because we don't have the feature. - assert "adoptionStages" not in response.data[0] + with self.feature({"organizations:release-adoption-stage": False}): + response = self.client.get(f"{url}?adoptionStages=1", format="json") + + assert response.status_code == 200, response.content + assert len(response.data) == 1 + # Not returned because we don't have the feature. + assert "adoptionStages" not in response.data[0] with self.feature("organizations:release-adoption-stage"): response = self.client.get(url, format="json")