Skip to content

test(alerts): Use placeholder in alert details integration test #29569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scttcper merged 2 commits into from
Oct 26, 2021
Merged

test(alerts): Use placeholder in alert details integration test #29569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3453ffe
fix(alerts): Use placeholder chart in integration test
scttcper Oct 26, 2021
e15e578
only wrap chart instead
scttcper Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
183 changes: 96 additions & 87 deletions static/app/views/alerts/rules/details/metricChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import space from 'app/styles/space';
import {AvatarProject, DateString, Organization, Project} from 'app/types';
import {ReactEchartsRef, Series} from 'app/types/echarts';
import {getUtcDateString} from 'app/utils/dates';
import getDynamicText from 'app/utils/getDynamicText';
import {
getCrashFreeRateSeries,
MINUTES_THRESHOLD_TO_DISPLAY_SECONDS,
Expand Down Expand Up @@ -528,93 +529,101 @@ class MetricChart extends React.PureComponent<Props, State> {
</ChartTitle>
{query ? filter : null}
</ChartHeader>
<ChartZoom
router={router}
start={start}
end={end}
onZoom={zoomArgs => handleZoom(zoomArgs.start, zoomArgs.end)}
>
{zoomRenderProps => (
<LineChart
{...zoomRenderProps}
isGroupedByDate
showTimeInTooltip
minutesThresholdToDisplaySeconds={minutesThresholdToDisplaySeconds}
forwardedRef={this.handleRef}
grid={{
left: space(0.25),
right: space(2),
top: space(2),
bottom: 0,
}}
yAxis={{
axisLabel: {
formatter: (value: number) =>
alertAxisFormatter(
value,
timeseriesData[0].seriesName,
rule.aggregate
),
},
max: maxThresholdValue > maxSeriesValue ? maxThresholdValue : undefined,
min: minChartValue || undefined,
}}
series={[...series, ...areaSeries]}
graphic={Graphic({
elements: this.getRuleChangeThresholdElements(timeseriesData),
})}
tooltip={{
formatter: seriesParams => {
// seriesParams can be object instead of array
const pointSeries = Array.isArray(seriesParams)
? seriesParams
: [seriesParams];
const {marker, data: pointData, seriesName} = pointSeries[0];
const [pointX, pointY] = pointData as [number, number];
const pointYFormatted = alertTooltipValueFormatter(
pointY,
seriesName ?? '',
rule.aggregate
);
const isModified =
dateModified && pointX <= new Date(dateModified).getTime();

const startTime = formatTooltipDate(moment(pointX), 'MMM D LT');
const {period, periodLength} = parseStatsPeriod(interval) ?? {
periodLength: 'm',
period: `${timeWindow}`,
};
const endTime = formatTooltipDate(
moment(pointX).add(
parseInt(period, 10),
periodLength as StatsPeriodType
),
'MMM D LT'
);
const title = isModified
? `<strong>${t('Alert Rule Modified')}</strong>`
: `${marker} <strong>${seriesName}</strong>`;
const value = isModified
? `${seriesName} ${pointYFormatted}`
: pointYFormatted;

return [
`<div class="tooltip-series"><div>`,
`<span class="tooltip-label">${title}</span>${value}`,
`</div></div>`,
`<div class="tooltip-date">${startTime} &mdash; ${endTime}</div>`,
`<div class="tooltip-arrow"></div>`,
].join('');
},
}}
onFinished={() => {
// We want to do this whenever the chart finishes re-rendering so that we can update the dimensions of
// any graphics related to the triggers (e.g. the threshold areas + boundaries)
this.updateDimensions();
}}
/>
)}
</ChartZoom>
{getDynamicText({
value: (
<ChartZoom
router={router}
start={start}
end={end}
onZoom={zoomArgs => handleZoom(zoomArgs.start, zoomArgs.end)}
>
{zoomRenderProps => (
<LineChart
{...zoomRenderProps}
isGroupedByDate
showTimeInTooltip
minutesThresholdToDisplaySeconds={minutesThresholdToDisplaySeconds}
forwardedRef={this.handleRef}
grid={{
left: space(0.25),
right: space(2),
top: space(2),
bottom: 0,
}}
yAxis={{
axisLabel: {
formatter: (value: number) =>
alertAxisFormatter(
value,
timeseriesData[0].seriesName,
rule.aggregate
),
},
max:
maxThresholdValue > maxSeriesValue
? maxThresholdValue
: undefined,
min: minChartValue || undefined,
}}
series={[...series, ...areaSeries]}
graphic={Graphic({
elements: this.getRuleChangeThresholdElements(timeseriesData),
})}
tooltip={{
formatter: seriesParams => {
// seriesParams can be object instead of array
const pointSeries = Array.isArray(seriesParams)
? seriesParams
: [seriesParams];
const {marker, data: pointData, seriesName} = pointSeries[0];
const [pointX, pointY] = pointData as [number, number];
const pointYFormatted = alertTooltipValueFormatter(
pointY,
seriesName ?? '',
rule.aggregate
);
const isModified =
dateModified && pointX <= new Date(dateModified).getTime();

const startTime = formatTooltipDate(moment(pointX), 'MMM D LT');
const {period, periodLength} = parseStatsPeriod(interval) ?? {
periodLength: 'm',
period: `${timeWindow}`,
};
const endTime = formatTooltipDate(
moment(pointX).add(
parseInt(period, 10),
periodLength as StatsPeriodType
),
'MMM D LT'
);
const title = isModified
? `<strong>${t('Alert Rule Modified')}</strong>`
: `${marker} <strong>${seriesName}</strong>`;
const value = isModified
? `${seriesName} ${pointYFormatted}`
: pointYFormatted;

return [
`<div class="tooltip-series"><div>`,
`<span class="tooltip-label">${title}</span>${value}`,
`</div></div>`,
`<div class="tooltip-date">${startTime} &mdash; ${endTime}</div>`,
`<div class="tooltip-arrow"></div>`,
].join('');
},
}}
onFinished={() => {
// We want to do this whenever the chart finishes re-rendering so that we can update the dimensions of
// any graphics related to the triggers (e.g. the threshold areas + boundaries)
this.updateDimensions();
}}
/>
)}
</ChartZoom>
),
fixed: <Placeholder height="200px" testId="skeleton-ui" />,
})}
</StyledPanelBody>
{this.renderChartActions(totalDuration, criticalDuration, warningDuration)}
</ChartPanel>
Expand Down