Skip to content

Conversation

@manuzope
Copy link
Contributor

@manuzope manuzope commented Oct 26, 2021

Previously, Gitlab tokens did not expire.

Now, by default, they do expire in 2 hours: https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/89791/diffs

We don't correctly support expiring Gitlab tokens right now.

So changing the instructions for Gitlab until we fix this (there is a ticket in the backlog) cause it's causing broken installations right now: #29010.

Before

Screen Shot 2021-10-26 at 10 13 40 AM

After

Screen Shot 2021-10-26 at 10 12 25 AM

How did I test this change

  1. Created a new application with "Expire access tokens" checked
  2. Made sure my local Sentry could communicate with it by fetching repositories
  3. Waited for 2 hours
  4. Tried to fetch repositories again but got a 401 from Gitlab
  5. Created a new application with "Expire access tokens" unchecked
  6. Repeated steps 2 & 3
  7. Tried to fetch repositories again and was successful

@manuzope manuzope requested a review from a team October 26, 2021 17:11
@manuzope manuzope merged commit 2b295e0 into master Oct 26, 2021
@manuzope manuzope deleted the fix-gitlab-new-instructions branch October 26, 2021 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants