Skip to content

fix(ui): all project position #29587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scefali merged 1 commit into from
Oct 26, 2021
Merged

fix(ui): all project position #29587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions static/app/components/organizations/multipleProjectSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ const SelectorFooterControls = ({
: t('Select My Projects');

return (
<FooterContainer>
<FooterContainer style={{justifyContent: message ? 'space-between' : 'flex-end'}}>
Copy link
Member

@evanpurkhiser evanpurkhiser Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tempted to say make a prop called hasMessage on FooterContainer

Copy link
Contributor Author

@scefali scefali Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, this requires less code to do the same thinng

{message && <FooterMessage>{message}</FooterMessage>}
<FooterActions>
{!disableMultipleProjectSelection && (
Expand Down Expand Up @@ -405,7 +405,6 @@ export default withRouter(MultipleProjectSelector);

const FooterContainer = styled('div')`
display: flex;
justify-content: space-between;
`;

const FooterActions = styled('div')`
Expand Down