Skip to content

fix(ui): move logic to styled component #29588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scefali merged 1 commit into from
Oct 26, 2021
Merged

fix(ui): move logic to styled component #29588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions static/app/components/organizations/multipleProjectSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ const SelectorFooterControls = ({
: t('Select My Projects');

return (
<FooterContainer style={{justifyContent: message ? 'space-between' : 'flex-end'}}>
<FooterContainer hasMessage={!!message}>
{message && <FooterMessage>{message}</FooterMessage>}
<FooterActions>
{!disableMultipleProjectSelection && (
Expand Down Expand Up @@ -403,8 +403,9 @@ const SelectorFooterControls = ({

export default withRouter(MultipleProjectSelector);

const FooterContainer = styled('div')`
const FooterContainer = styled('div')<{hasMessage: boolean}>`
display: flex;
justify-content: ${p => (p.hasMessage ? 'space-between' : 'flex-end')};
Copy link
Contributor

@davidenwang davidenwang Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the parentheses here around p.hasMessage ? ... 'flex-end'

Copy link
Contributor Author

@scefali scefali Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidenwang I believe prettier added them for me

Copy link
Member

@evanpurkhiser evanpurkhiser Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's correct it's prettier

`;

const FooterActions = styled('div')`
Expand Down