Fix(digests): Fix error with empty digests #29594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We changed the return type of `build_digest`, but mypy missed this due to the return typing being `Any`. Luckily this only caused us to throw errors on empty digests which couldn't send, and didn't block any actual emails from going out. Fixes SENTRY-SJD
evanpurkhiser
approved these changes
Oct 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the return type of
build_digest, but mypy missed this due to the return typing beingAny. Luckily this only caused us to throw errors on empty digests which couldn't send, and didn'tblock any actual emails from going out.
Fixes SENTRY-SJD