Skip to content

digests: Add logging to see how often we're missing records from digests #29596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wedamija merged 2 commits into from
Oct 27, 2021
Merged

digests: Add logging to see how often we're missing records from digests #29596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a26b42c
digests: Add logging to see how often we're missing records from digests
wedamija Oct 27, 2021
38a36dc
upgrade to warn, add a little more info to log
wedamija Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/sentry/digests/backends/redis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,17 @@ def digest(
# If the record value is `None`, this means the record data was
# missing (it was presumably evicted by Redis) so we don't need to
# return it here.
yield [record for record in records if record.value is not None]
filtered_records = [record for record in records if record.value is not None]
if len(records) != len(filtered_records):
logger.warning(
"Filtered out missing records when fetching digest",
extra={
"key": key,
"record_count": len(records),
"filtered_record_count": len(filtered_records),
},
)
yield filtered_records

script(
connection,
Expand Down