feat(cmp_alerts): Show comparison data in dashed line in alert event stat chart #29603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
scttcper
approved these changes
Oct 27, 2021
taylangocmen
force-pushed
the
taylangocmen/change-alerts-graph-data
branch
from
6bd2e62 to
a4d2e09
Compare
scttcper
approved these changes
Oct 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the event stats chart in the alert rule creation to show the comparison stats in a dashed line. Also added a marker formatter function to conditionally format the marker in the chart tooltip. Fixed the
comparisonDeltain the events stats request, should be seconds in the request but it's in minutes on thealertRule, similarly tointervalOld chart:
New chart: