feat: Restrict hard deletions on users to permission #29612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcramer
commented
Oct 27, 2021
dcramer
force-pushed
the
feat/lock-down-user-deletes
branch
from
977604f to
14b7126
Compare
dcramer
force-pushed
the
feat/lock-down-user-deletes
branch
from
14b7126 to
e2d35ce
Compare
This also adjusts several code paths to use the new `has_superuser_permission` helper.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adjusts several code paths to use the new
has_superuser_permissionhelper, and in doing so more correctly locks down certain code paths to admins only (vs superusers only).Fixes #29609