fix(suspect): Increase examples to 5 per suspect #29613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showing only 3 examples per suspect is too little, bumping this up to 5.
wmak
approved these changes
Oct 27, 2021
|
|
||
| @pytest.mark.skip("setting snuba config is too slow") | ||
| def test_span_group_prefixed_with_zeros(self): | ||
| self.update_snuba_config_ensure({"write_span_columns_projects": f"[{self.project.id}]"}) |
Member
Author
There was a problem hiding this comment.
Just removing it from this test since it's being skipped anyways. Going to be updating this using mocks in an upcoming PR 👍
k-fish
approved these changes
Oct 28, 2021
| order_column: str, | ||
| suspects: List[SuspectSpan], | ||
| per_suspect: int = 3, | ||
| per_suspect: int = 5, |
Member
There was a problem hiding this comment.
I usually would prefer a max limit enforced by the api and let the frontend decide how many get returned, but I guess this is simple enough for now.
Member
Author
There was a problem hiding this comment.
Will update this in a follow up after i clean up the tests a little.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing only 3 examples per suspect is too little, bumping this up to 5.