fix(cmp_alerts): Allow comparison event frequency percent alerts to set a value > 100 #29624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et a value > 100 Event frequency percent alerts are capped at a value between 0-100%, which makes sense for that kind of alert. When we change these to be comparison alerts this doesn't make sense though, since we're just taking into account relative change. This pr changes the validation to be conditional.
wedamija
force-pushed
the
danf/cmp_alerts_fix_freq_validation
branch
from
e49c331 to
5adf425
Compare
taylangocmen
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event frequency percent alerts are capped at a value between 0-100%, which makes sense for that kind
of alert. When we change these to be comparison alerts this doesn't make sense though, since we're
just taking into account relative change. This pr changes the validation to be conditional.