feat(suspect-spans): Add ops filter to spans tab #29640
Conversation
This change adds a filter dropdown to the spans page that can be used to filter the specific span ops. This is limited to the top 20 most frequent span ops at the moment.
| }; | ||
| } | ||
|
|
||
| const spanOp = decodeScalar(location.query.spanOp); |
There was a problem hiding this comment.
Not for this PR, but as an aside, looking at how many of these we end up doing, I feel like we should have a useLocation and then have useQueryField('QueryField.SPAN_OP') eventually, with enums to ensure we don't have typos selecting from the query 🤔
There was a problem hiding this comment.
That makes sense to me, we can follow up with this later.
| <Radio | ||
| radioSize="small" | ||
| checked={spanOp.op === currentOp} | ||
| onChange={() => {}} |
There was a problem hiding this comment.
Hmm I didn't know we would do a fake radio and make the whole row clickable but that's probably better considering a dropdown is ephemeral. I'm guessing we do this elsewhere?
There was a problem hiding this comment.
We actually have this pattern for the ops breakdown filter already. I had to add this empty onChange handler to make a warning go away about the radio button missing a change handler.
There was a problem hiding this comment.
Yeah it's fine, the empty onChange is what caught my eye, radios can have small click areas anyway.
This change adds a filter dropdown to the spans page that can be used to filter
the specific span ops. This is limited to the top 20 most frequent span ops at
the moment.