Skip to content

Conversation

@ceorourke
Copy link
Member

@ceorourke ceorourke commented Oct 28, 2021

We've deleted all the code related to the Jira AC, Clubhouse, Teamwork, and VSTS plugins, so now we can remove all the ProjectOption data for those plugins.

There are 24,196 rows of this data.
select count(id) from sentry_projectoptions where key in ('jira-ac:enabled', 'vsts:default_project', 'vsts:enabled', 'vsts:instance', 'clubhouse:enabled', 'clubhouse:project', 'clubhouse:token', 'teamwork:enabled', 'teamwork:token', 'teamwork:url')

@ceorourke ceorourke requested a review from a team as a code owner October 28, 2021 18:52
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth on whether we needed this to be true or false, the amount of data is fairly small.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the right choice to make it dangerous, just since the table has 5mm rows and it'll take a while to get through them all

@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL

--
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
--

@ceorourke ceorourke force-pushed the ceorourke/rm-plugin-data branch from c9a79e7 to 76ec986 Compare October 28, 2021 19:22
@ceorourke ceorourke changed the title ref(plugins): Remove deleted plugins data ref(plugins): Remove deleted plugins project options Oct 29, 2021
@ceorourke
Copy link
Member Author

ceorourke commented Oct 29, 2021

I need to remove rows in sentry_repository too, it's only 30 but it's causing an error:

select * from sentry_repository where provider='visualstudio'

just FYI that will be in an upcoming PR.

I can also remove the associated commits (4 rows):

select * from sentry_commit 
join sentry_repository on sentry_repository.id=sentry_commit.repository_id 
where sentry_repository.provider='visualstudio'

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the right choice to make it dangerous, just since the table has 5mm rows and it'll take a while to get through them all

@ceorourke ceorourke merged commit 1b8d0a3 into master Oct 29, 2021
@ceorourke ceorourke deleted the ceorourke/rm-plugin-data branch October 29, 2021 18:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants