-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(plugins): Remove deleted plugins project options #29645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth on whether we needed this to be true or false, the amount of data is fairly small.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the right choice to make it dangerous, just since the table has 5mm rows and it'll take a while to get through them all
|
This PR has a migration; here is the generated SQL --
-- MIGRATION NOW PERFORMS OPERATION THAT CANNOT BE WRITTEN AS SQL:
-- Raw Python operation
-- |
c9a79e7 to
76ec986
Compare
|
I need to remove rows in
just FYI that will be in an upcoming PR. I can also remove the associated commits (4 rows): |
markstory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably the right choice to make it dangerous, just since the table has 5mm rows and it'll take a while to get through them all
We've deleted all the code related to the Jira AC, Clubhouse, Teamwork, and VSTS plugins, so now we can remove all the
ProjectOptiondata for those plugins.There are 24,196 rows of this data.
select count(id) from sentry_projectoptions where key in ('jira-ac:enabled', 'vsts:default_project', 'vsts:enabled', 'vsts:instance', 'clubhouse:enabled', 'clubhouse:project', 'clubhouse:token', 'teamwork:enabled', 'teamwork:token', 'teamwork:url')