ref(sentry-metrics): Remove temp redis indexer #29650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Oct 29, 2021
Member
jjbayer
left a comment
jjbayer
left a comment
There was a problem hiding this comment.
There's a setting for this, should we remove that as well?
sentry/src/sentry/conf/server.py
Lines 2422 to 2423 in 7d91819
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context
The
RedisMockIndexerwas added way back in #28431. It was added to unblock folks while the postgres indexer was still in the works.There isn't any reason I can see for keeping this around now since we have the postgres indexer and we also have a mock indexer that can be used in tests that don't need postgres.