chore(deps): Upgrade eslint-config-sentry@1.67.0 #29657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
reviewed
Nov 3, 2021
tests/js/.eslintrc.js
Outdated
Comment on lines
3
to
6
| rules: { | ||
| 'testing-library/render-result-naming-convention': 'off', | ||
| 'testing-library/prefer-screen-queries': 'off', | ||
| }, |
Member
There was a problem hiding this comment.
Should these be in eslint-config-sentry?
Member
Author
There was a problem hiding this comment.
Unfortunately, they get overridden by this extend if they are there.
We'll be able to get rid of testing-library/prefer-screen-queries line soon, just one more big file to go.
Once we get the extends in overrides feature with the upgraded eslint, we'll be able to delete this whole file.
Member
Author
There was a problem hiding this comment.
Actually, I can put them there 👍 Just had the wrong order when I was testing it previously.
matejminar
changed the title
evanpurkhiser
approved these changes
Nov 4, 2021
| ); | ||
|
|
||
| screen.findByText('mock_AwsLambdaProjectSelect'); | ||
| await screen.findByText('mock_AwsLambdaProjectSelect'); |
Member
There was a problem hiding this comment.
Should it be getByText if this didn't need to resolve before?
matejminar
deleted the
chore/deps/upgrade-eslint-sentry-testing-library
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the addition of eslint-plugin-testing-library (getsentry/eslint-config-sentry#115).